cli: opt-in telemetry categories + config echo#178
Merged
Conversation
db9c6bb to
220a993
Compare
220a993 to
90c1bee
Compare
Rework `browsers create/update --telemetry` for the opt-in model: - `--telemetry=all` captures the default set, `--telemetry=off` disables, and `--telemetry=console,network` captures exactly the listed categories (replace semantics). Drops the old name=on/off DSL. - settableCategories expands to the full 9 (control, connection, system, screenshot, captcha added); monitor is not settable (auto). - After create/update, echo the categories telemetry will capture. - `telemetry stream --categories` filter set covers all event categories including monitor; category now read from the SDK's typed field directly. NOTE: requires kernel-go-sdk >= v0.64 (new category fields). That bump is not included here because it also requires migrating cmd/proxies to the new SDK proxy API (unrelated). This change rebases on top of that SDK-bump PR; it does not compile against the current pinned SDK (v0.58). Co-authored-by: Cursor <cursoragent@cursor.com>
90c1bee to
ce2f532
Compare
|
Created a monitoring plan for this PR. What this PR does: Changes the Intended effect:
Risks:
Status updates will be posted automatically on this PR as monitoring progresses. |
hiroTamada
approved these changes
Jun 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes
kernel browsers create/update --telemetry:--telemetry=all-> default category set--telemetry=off-> disable--telemetry=console,network-> capture exactly those categories (opt-in, replace semantics). The oldname=on/offDSL is removed.settableCategoriesnow covers all 9 (console, network, page, interaction, control, connection, system, screenshot, captcha).monitoris not settable (auto-managed, flows when a CDP category is captured).telemetry stream --categoriesfilter set now covers every event category incl.monitor; event category is read from the SDK's typedCategoryfield (removed the JSON/prefix fallback and the stalemonitor->systemmapping).Test plan
--telemetry=all/=off/=console,network; confirm the echoed config;telemetry stream --categories monitorNote
Medium Risk
Changes user-facing
--telemetrysemantics (breaking for scripts usingname=on/off) and how stream filtering maps categories; behavior is localized to CLI with solid test coverage.Overview
Reworks browser
--telemetryon create/update to opt-in category selection with replace semantics:all(default set),off, or a comma list likeconsole,networkthat captures only those categories. The oldname=on/offDSL is removed.Settable categories expand to nine (
control,connection,system,screenshot,captcha, etc.);monitorstays non-settable but is included intelemetry stream --categories. After create/update, the CLI prints which categories telemetry will capture when--telemetrywas used.Streaming uses the SDK’s typed
Categoryfield (drops JSON/prefix fallback andmonitor→systemremapping). Tests and flag help text are updated for the new behavior.Reviewed by Cursor Bugbot for commit ce2f532. Bugbot is set up for automated code reviews on this repo. Configure here.