Skip to content

fix: WIP address export issues - #3664

Open
igorDykhta wants to merge 1 commit into
masterfrom
igr/export-geoarrow-issues
Open

fix: WIP address export issues#3664
igorDykhta wants to merge 1 commit into
masterfrom
igr/export-geoarrow-issues

Conversation

@igorDykhta

Copy link
Copy Markdown
Collaborator

No description provided.

Signed-off-by: Ihor Dykhta <ihordykhta@Ihors-MacBook-Pro.local>
Copilot AI lite review requested due to automatic review settings August 24, 2026 08:35

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR improves geometry export/re-import behavior by adding safer serialization for GeoArrow cells and by detecting GeoJSON geometry strings during field type inference, with accompanying Node test coverage.

Changes:

  • Add formatGeoArrowValue to serialize GeoArrow/WKB cells into re-importable strings (prefer WKT/GeoJSON, fallback to hex).
  • Add isGeoJsonGeometryString and integrate it into getFieldsFromData so GeoJSON-in-CSV columns classify as geometry.
  • Extend Node tests to cover GeoJSON-geometry-string detection and GeoArrow CSV roundtripping.

Reviewed changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
test/node/utils/dataset-utils-test.js Adds unit tests for isGeoJsonGeometryString and fixes t.end() placement for isHexWkb test.
test/node/utils/data-utils-test.js Adds tests ensuring GeoArrow cells format to strings and parseFieldValue uses the GeoArrow formatter.
test/node/utils/data-processor-test.js Adds tests for GeoJSON-in-geometry column detection and GeoArrow→CSV→reimport roundtrip.
src/utils/src/data-utils.ts Implements formatGeoArrowValue and wires it into FIELD_DISPLAY_FORMAT for geoarrow fields.
src/processors/src/data-processor.ts Adds Arrow field classification logging helper invoked from arrowSchemaToFields.
src/common-utils/src/data.ts Introduces isGeoJsonGeometryString for recognizing GeoJSON geometry/feature JSON strings.
src/common-utils/src/data-type.ts Uses isGeoJsonGeometryString during type inference to classify GeoJSON strings as geometry.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment on lines +579 to +582

logAddedGeometryFields(fields);
return fields;
}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants