fix: google drive provider prevent auto popup - #3660
Merged
Conversation
igorDykhta
commented
Aug 22, 2026
Collaborator
- google drive storage provider: prevent auto popup on token refresh
Signed-off-by: Ihor Dykhta <ihordykhta@Ihors-MacBook-Pro.local>
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the demo app’s Google Drive provider to prevent automatic OAuth popups during token checks.
Changes:
- Removes silent GIS token refresh.
- Adjusts login prompts based on stored session state.
- Updates token request comments.
Suppressed comments (1)
examples/demo-app/src/cloud-providers/google-drive/google-drive-provider.js:85
_readStorage()deliberately returnsnullwhen localStorage is unavailable, but this new no-GIS path then ignores the in-memory token and clears_accessToken._requestAccessTokensets that field even when_writeStorageis a no-op, so a successful login in a browser without usable storage cannot be used for list/upload/download. Keep the in-memory token as a no-popup fallback and let the existing 401 handling invalidate it.
// Reuse cached token only while expiresAt says it is still valid.
// Do not call GIS here: requestAccessToken always opens a popup, and
// CloudTile calls getUser() on mount (Load From Storage / Save Map).
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
lixun910
approved these changes
Aug 22, 2026
added 2 commits
August 23, 2026 11:32
Signed-off-by: Ihor Dykhta <ihordykhta@Ihors-MacBook-Pro.local>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.