chore(ci,docs): point CI at master, make E2E manual, add make test + RELEASE SOP#89
Merged
Merged
Conversation
…+ RELEASE SOP The build-zip/lint/prettier/test/e2e workflows triggered `push` on `main` — a branch that doesn't exist here (the branch is `master`) — so those push gates never fired on releases. Repoint them to `master` (test keeps `develop`). E2E drives the extension against a physically connected KeepKey and can't pass on GitHub's headless runners, so convert it to `workflow_dispatch` (manual) instead of leaving a dead `main` trigger. Add the missing `make test` target — the Makefile wraps every other pnpm script but had no unit-test target, so `make test` errored. Add RELEASE.md documenting the develop → release/x.y.z → master → tag → build → sync-back flow, including why the sync-back step matters (the develop/master divergence it prevents). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release-prep housekeeping ahead of the 0.0.34 release. No runtime code changes.
CI trigger fix (
main→master)build-zip,lint,prettier,test, ande2eall hadpushtriggers onmain— a branch that doesn't exist in this repo (it'smaster). So those push gates never fired on releases. Repointed:build-zip/lint/prettier→mastertest→master+developE2E → manual
E2E drives the extension against a physically connected KeepKey, which GitHub's headless runners don't have, so it can never pass in CI. Converted
e2e.ymltoworkflow_dispatch(run from the Actions tab /make e2elocally) instead of leaving a deadmaintrigger.make testThe Makefile wrapped every other pnpm script but had no
testtarget, somake testerrored. Added it (pnpm test), matching the existing thin-wrapper pattern.RELEASE.md
First written release SOP:
develop → release/x.y.z → master → tag → build → **sync back to develop**. Documents the CI gates, why E2E isn't one, and the divergence lesson (the missed sync-back that leftdevelopcarrying codemasterhad already removed).Verification
make test91/91,make type-check15/15🤖 Generated with Claude Code