fix: Enable Zabbix ID deduplication - #6745
Merged
shahargl merged 1 commit intoSep 2, 2026
Merged
Conversation
Contributor
|
🌟 Well done @mvanhorn! Two PRs merged already! 🎉🥳 With your second PR, you're on a roll, and your contributions are already making a difference. 🌟 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #4767
📑 Description
Declare
idasZabbixProvider's default fingerprint field, following the existing Graylog, Wazuh, Checkmk, and Dynatrace provider pattern. Keep the change at the provider contract boundary:ProvidersFactory.get_all_providers()already copies this declaration intodefault_fingerprint_fields, andget_default_deduplication_rules()already turns non-empty values into enabled provider defaults. Add factory-level regression coverage that verifies Zabbix metadata exposesidand that the generated Zabbix default rule uses it, while isolating the factory caches so the assertions cannot pass because of earlier test state.Zabbix alerts carry their problem occurrence identifier in the normalized alert
id, butZabbixProviderdoes not declare a default fingerprint field. Provider discovery therefore publishes no default fingerprint fields for Zabbix, so the deduplication service omits the provider's default rule and a Zabbix-only installation can show an empty deduplication page. Graylog already declaresFINGERPRINT_FIELDS = ["id"]in the current tree, leaving Zabbix as the concrete unresolved case described by the latest human report. The existing custom-rule API workaround confirms thatidis accepted by the deduplication path once supplied.✅ Checks
ℹ Additional Information
Nothing beyond what is described above.