Skip to content

fix(data-grid): support adaptive and wrapped pagination - #128

Open
focus0802 wants to merge 2 commits into
keenthemes:mainfrom
focus0802:codex/data-grid-pagination-window-v2
Open

fix(data-grid): support adaptive and wrapped pagination#128
focus0802 wants to merge 2 commits into
keenthemes:mainfrom
focus0802:codex/data-grid-pagination-window-v2

Conversation

@focus0802

@focus0802 focus0802 commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

Changes

  • Replace grouped page buttons with an adaptive pagination window showing the first and last pages, adjacent pages around the current page, and ellipses when pages are hidden.
  • Remove the horizontal overflow wrapper and the forced minimum width from the Base UI and Radix implementations.
  • Allow the pagination controls to wrap on narrow screens while keeping the full control set accessible, including previous/next buttons, neighboring pages, and ellipses.
  • Keep the pagination layout on a single line at desktop breakpoints.
  • Preserve the existing i18n labels, page-size selector behavior, and accessible pagination controls.
  • Regenerate the related Base/Radix registry metadata and artifacts across all style variants.

Verification

  • Targeted Prettier: passed.
  • Targeted ESLint for both pagination implementations: passed.
  • pnpm components:build, pnpm components:packages, and pnpm registry:build: passed; 3,466 generated files and 3,450 verified registry items.
  • Local admin DataGrid regression suite: 6 test files, 58/58 passed.
  • Full repository pnpm typecheck currently reports pre-existing unrelated errors in the upstream baseline; the changed pagination files pass the targeted checks above.
  • pnpm registry:verify: Data Grid sets and Base/Radix alignment pass; the repository still reports the existing 34 Cascader dependency declaration issues.

Built and tested on upstream main at commit 8a2c701 (v2.5.2).

Replace grouped page buttons with an adaptive pagination window showing the first and last pages, adjacent pages around the current page, and ellipses when pages are hidden.

Remove the horizontal overflow wrapper and the forced minimum width from the Base UI and Radix implementations.

Allow the pagination controls to wrap on narrow screens while keeping the full control set accessible, including previous/next buttons, neighboring pages, and ellipses.

Keep the pagination layout on a single line at desktop breakpoints.

Regenerate the related Base/Radix registry metadata and artifacts across all style variants.
@vercel

vercel Bot commented Sep 3, 2026

Copy link
Copy Markdown

@focus0802 is attempting to deploy a commit to the Keenthemes Team on Vercel.

A member of the Team first needs to authorize it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant