Set up AI Hero engineering skills - #3
Draft
keeganmoody33 wants to merge 1 commit into
Draft
Conversation
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
|
|
||
| - The full diff command and commit list. | ||
| - The list of standards-source files you found in step 3, **plus the smell baseline from step 3** pasted in full — the sub-agent has no other access to it. | ||
| - The brief: "Report — per file/hunk where relevant — (a) every place the diff violates a documented standard: cite the standard (file + the rule); and (b) any baseline smell you spot: name it and quote the hunk. Distinguish hard violations from judgement calls — documented-standard breaches can be hard, but baseline smells are always judgement calls, and a documented repo standard overrides the baseline. Skip anything tooling enforces. Under 400 words." |
Contributor
There was a problem hiding this comment.
When this mandatory review step runs, it requests an Agent tool with general-purpose subagents even though the added Codex configuration exposes no such interface, causing the workflow to stop before either review is produced. The same broken delegation mechanism is used by the architecture exploration and design-it-twice flows.
Prompt To Fix With AI
This is a comment left during a code review.
Path: .agents/skills/code-review/SKILL.md
Line: 66
Comment:
**Unsupported delegation interface**
When this mandatory review step runs, it requests an `Agent` tool with `general-purpose` subagents even though the added Codex configuration exposes no such interface, causing the workflow to stop before either review is produced. The same broken delegation mechanism is used by the architecture exploration and design-it-twice flows.
How can I resolve this? If you propose a fix, please make it concise.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Why
This gives PROPER-RESPECT a repeatable, repository-aware workflow for product grilling, domain modeling, specifications, ticketing, TDD, implementation, debugging, and review.
Validation
git diff --checkGreptile Summary
Adds a repository-scoped AI engineering workflow.
Confidence Score: 3/5
The PR should not merge until the installed skills use delegation instructions supported by the target Codex runtime.
Several promoted workflows depend on mandatory
Agentcalls and named subagent types that the added OpenAI configuration does not provide, preventing those workflows from completing when invoked..agents/skills/code-review/SKILL.md, .agents/skills/improve-codebase-architecture/SKILL.md, and .agents/skills/codebase-design/DESIGN-IT-TWICE.md
Important Files Changed
Flowchart
%%{init: {'theme': 'neutral'}}%% flowchart LR Idea[Idea or request] --> Grill[Grill with docs] Grill --> Spec[Specification] Spec --> Tickets[GitHub tickets] Tickets --> Implement[Implementation with TDD] Implement --> Review[Code review] Bugs[Reported bugs] --> Triage[Triage] Triage --> Tickets Fog[Large uncertain effort] --> Wayfinder[Wayfinder decisions] Wayfinder --> SpecPrompt To Fix All With AI
Reviews (1): Last reviewed commit: "Set up AI Hero engineering skills" | Re-trigger Greptile