Fix upload task response body size - #380
Draft
ffittschen wants to merge 1 commit into
Draft
ffittschen wants to merge 1 commit into
ffittschen wants to merge 1 commit into
Conversation
LoggerStore sets responseBodySize for data and download tasks, but not for upload tasks, so it stayed at its initial value of -1 even when the upload's response body was stored. Set it from the response body, the same way as for data tasks.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes
responseBodySizestaying at-1for upload tasks. The root cause wasLoggerStoresetting it for data and download tasks but not for upload tasks. So even with the response body stored, the inspector showed an empty, disabled Response Body cell, "Copy Response" was hidden, and size filters and sorting skipped upload tasks. The fix sets it from the response body, the same way as for data tasks.Found while working on #378.
How to test
uploadTask(with:from:)and withuploadTask(with:fromFile:)to an endpoint that returns a body. Assert that the task's response size equals the body size, and that the Response Body cell opens.204response stores0.