fix(env): compose profile URLs and repeated header overrides correctly - #37
Open
rupayon123 wants to merge 3 commits into
Open
rupayon123 wants to merge 3 commits into
rupayon123 wants to merge 3 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem and change
Environment profiles could leave stale duplicate headers after a CLI override and silently corrupt endpoint URLs when the configured base contained a query or fragment.
Replace every profile value for an overridden header name, case-insensitively, while retaining all explicitly supplied CLI values and the existing first-slot ordering. Compose URL paths through net/url; preserve the base query unless the request supplies one, and apply request fragments separately. Escaped slashes remain escaped.
Validation
Both regression groups failed before their fixes. Tests cover repeated profile/CLI headers, unchanged profile input, base/request query strings, empty explicit queries, fragments, query-only references and escaped slashes. Full
env -u NO_COLOR go test ./...,go vet ./..., formatting and diff checks pass. golangci-lint is unavailable locally; remote CI is tracked separately. Prepared with AI assistance.Explicit HTTP, HTTPS, WS and WSS URLs are also recognized case-insensitively when applying a profile. Four mixed-case regression cases reproduced the incorrect host substitution before the fix and pass afterward.