fix: preserve json values and evaluate array filter paths correctly - #31
Open
rupayon123 wants to merge 5 commits into
Open
rupayon123 wants to merge 5 commits into
rupayon123 wants to merge 5 commits into
Conversation
Contributor
Author
|
Additional fixes pushed to this branch:
Full Go tests, go vet and build pass. The added quoted-field cases cover dotted/bracketed names, escaped quotes, Unicode escapes, empty names, projections and malformed syntax. Today's changes have no new findings under golangci-lint v2.13.2 using a migrated copy of the repository configuration. This is a scoped lint result: a full CLI-branch scan still reports 93 findings outside today's changes; the legacy v1 linter cannot read the installed Go 1.27 export format. Prepared with AI assistance. Changes are submitted for review; this is not a claim of maintainer approval. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JSON filtering currently corrupts large numeric IDs, rejects documented
.users[].nameprojections, turns empty arrays intonull, and mishandles consecutive or malformed array brackets (including a panic for.items][0]).This PR fixes those independent defects in four commits:
[].Regression tests reproduce each defect before its fix. Validation:
env -u NO_COLOR go test ./...,go vet ./internal/filter, andgit diff --checkpass with Go 1.27.1 on macOS. NO_COLOR is unset for the suite because existing printer tests explicitly expect ANSI output.No new dependencies. Prepared with AI assistance; tests were run locally.