refactor: simplify schemas, manifest builder, and registry error hand… - #31
Merged
Conversation
…ling - ManifestSchema validates PascalCase Docker keys, outputs camelCase via v.transform; Manifest type uses InferOutput - DockerTarPusherOptionsSchema uses v.fallback for defaults, eliminating the redundant ApplicationConfigurationSchema; constructor now validates via v.parse - Replace stateful ManifestBuilder class with a pure buildManifest function; fix layer accumulation bug across multiple RepoTags - Use isAxiosError consistently in DockerRegistryService catch blocks Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
🦋 Changeset detectedLatest commit: 41041f9 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Integration test hitting a real registry can exceed the default 5s limit. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
Contributor
Coverage Report
File Coverage
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
- Add compose.yaml with a registry service on port 5001, matching .env.test - Remove hardcoded REGISTRY_URL from the Run tests step; .env.ci already provides the correct port (15000) matching the service port mapping Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
Align compose.yaml and .env.test on port 15000 to match the CI service port mapping. Remove .env.ci and the CI conditional in vitest.config.ts. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
v.fallback does not affect the output type — use v.pipe + v.transform with ?? to apply defaults for chunkSize and sslVerify, matching the pattern already used by ManifestSchema. Remove unused Manifest, Image, and ProgressCallback type exports. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
Parameterize the integration test with test.each over busybox, alpine, and nginx. Each image gets its own tarball in beforeAll to avoid races. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
beforeAll pulls multiple images on a self-hosted Pi runner — bump its timeout to 120s. Add afterAll to remove the tarballs from /tmp since the runner persists between runs. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
nginx upload on the Pi runner exceeds 10s. 30s gives enough headroom for larger images. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
Eliminate the intermediate layersMetadata array and layerPromises variable by inlining the upload map directly into Promise.all and passing layerResults straight to buildManifest. Also doubles testTimeout from 30s to 60s. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ling