feat: refine card activity feed controls by separating notes/comments#527
Open
NDCallahan wants to merge 1 commit into
Open
feat: refine card activity feed controls by separating notes/comments#527NDCallahan wants to merge 1 commit into
NDCallahan wants to merge 1 commit into
Conversation
Contributor
|
Great start @NDCallahan Few bits of feedback:
Give me a shout if I can help with anything |
Author
So, it appears, there might need to be additions to the API. I'm definiely not a programming expert on the backend. Here's what I think is needed based on review. Please let me know how far off base that I am. Proposed SolutionPhase 1: API EnhancementExtend the // Input Parameters
{
cardPublicId: string // Required, existing
limit?: number // Optional, existing (1-100, default: 10)
cursor?: string // Optional, existing (ISO datetime for pagination)
filter?: 'all' | 'activity' | 'comments' // NEW
sortOrder?: 'asc' | 'desc' // NEW (default: 'desc')
}
// Response (unchanged structure)
{
activities: ActivityItem[]
hasMore: boolean
nextCursor: string | null
}Phase 2: Backend ImplementationModify the
Filtering Logic: Phase 3: Frontend UpdatesModify
|
Contributor
|
That sounds correct to me @NDCallahan Give me a shout if I can help with anything |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Separates activity from comments/notes for better organization and sorting. This improves the card view by giving users a dedicated activity feed that's distinct from user comments and notes, making it easier to track changes and updates. Additionally the activies can be sorted.
Type of change
Checklist
Linked issue
Closes #525
Screenshots
Short Video of functionality