Repository navigation
feat(modeldeployment): add nodeLabelSelector for InferenceSet GPU node selection - #248
Merged
Merged
Conversation
…e selection Expose the new v1beta1 InferenceSet spec.template.resource.labelSelector (kaito-project/kaito#2444) as the `nodeLabelSelector` chart value. Empty omits the field, so existing renders are unchanged. The schema restricts it to matchLabels/matchExpressions. Also update the instanceType docs: it is now optional on BYO clusters and filters nodes by instance type. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
zhuangqh
requested review from
Fei-Guo,
rambohe-ch and
techworldhello
as code owners
October 21, 2026 10:04
rambohe-ch
approved these changes
Oct 21, 2026
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reason for Change:
Expose the new v1beta1 InferenceSet spec.template.resource.labelSelector (kaito-project/kaito#2444) as the
nodeLabelSelectorchart value. Empty omits the field, so existing renders are unchanged. The schema restricts it to matchLabels/matchExpressions. Also update the instanceType docs: it is now optional on BYO clusters and filters nodes by instance type.Requirements
Issue Fixed:
Notes for Reviewers: