Repository navigation
fix(modeldeployment): use v1beta1 InferenceSet and allow empty instanceType - #244
Merged
Merged
Conversation
…ceType KAITO's v1alpha1 InferenceSet webhook rejects spec.template.resource.instanceType when the operator runs with nodeProvisioner=byo. kaito-project/kaito#2438 relaxed this only for v1beta1, so ModelDeployments on BYO clusters fail with: instanceType must be empty when nodeProvisioner is byo - Render the InferenceSet as kaito.sh/v1beta1 (served since KAITO v0.11, storage version). - Allow an empty instanceType: drop minLength from the values schema and omit the field (resource: {}) when unset. - Update README/values docs and e2e InferenceSet GVR/GVKs to v1beta1. Verified with helm template/lint and server-side dry-run against a BYO AKS cluster running KAITO 0.13.0-rc.2: v1beta1 with instanceType is admitted, while v1alpha1 reproduces the rejection. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Signed-off-by: Qinghui Zhuang <qzhuang@microsoft.com>
zhuangqh
requested review from
Fei-Guo,
rambohe-ch and
techworldhello
as code owners
October 19, 2026 06:55
rambohe-ch
approved these changes
Oct 19, 2026
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reason for Change:
KAITO's v1alpha1 InferenceSet webhook rejects spec.template.resource.instanceType when the operator runs with nodeProvisioner=byo. kaito-project/kaito#2438 relaxed this only for v1beta1, so ModelDeployments on BYO clusters fail with:
instanceType must be empty when nodeProvisioner is byo
Verified with helm template/lint and server-side dry-run against a BYO AKS cluster running KAITO 0.13.0-rc.2: v1beta1 with instanceType is admitted, while v1alpha1 reproduces the rejection.
Requirements
Issue Fixed:
Notes for Reviewers: