Repository navigation
Conversation
Fei-Guo
requested review from
rambohe-ch,
techworldhello and
zhuangqh
as code owners
October 6, 2026 17:21
zhuangqh
approved these changes
Oct 7, 2026
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reason for Change:
Adds GPU and inference observability wiring for Azure Monitor managed Prometheus across the two chart layers:
charts/modelharness(per-namespace): newtemplates/azure/podmonitor.yamlrenders anazmonitoring.coreos.com/v1PodMonitor that scrapes every pod in the workload namespace across the EPP, Istio gateway, and vLLM metric surfaces, lifting the inferencepool / gateway / shadow-pod / workspace pod labels onto the emitted series. Gated oncloudprovider=azure+ a newazure.podMonitortoggle, and additionally on.Capabilities.APIVersions.Has "azmonitoring.coreos.com/v1/PodMonitor"so an install against a cluster without the Azure Managed Prometheus add-on silently skips the CR instead of failing on an unknown kind. Values andvalues.schema.jsonupdated (enabled/name/interval).charts/productionstack(cluster-wide): newtemplates/azure/ama-metrics-settings-configmap.yamlrenders the add-on's well-knownama-metrics-settings-configmapinkube-systemenabling thedcgmexporterdefault scrape target, so the add-on collects raw NVIDIA DCGM GPU metrics cluster-wide. Gated oncloudprovider=azurevia a newazure.amaMetricsSettingstoggle (defaulttrue; renders nothing on non-Azure installs).This gives per-namespace inference metrics plus cluster-wide raw GPU metrics in Azure Monitor managed Prometheus, with both templates safe to apply on clusters where the add-on / CRD is absent.
Requirements
Notes for Reviewers:
labelLimit: 63,labelNameLengthLimit: 511,labelValueLengthLimit: 1023) are hand-picked guardrails, not Azure/Prometheus defaults (Prometheus default is0= unlimited). Flag if you'd prefer them tunable or dropped.ama-metrics-settings-configmap. If a cluster already has one (platform- or operator-managed),helm installwill conflict — setazure.amaMetricsSettings.enabled=falsethere. Default istrue..Capabilitiescaveat: capability discovery needs a live API server, so a barehelm template(no--validate/--api-versions) will not render the PodMonitor even on a cluster that has the CRD. Relevant for CI snapshot tests.values.schema.jsonexists forcharts/productionstack, so onlycharts/modelharness's schema was updated.podMonitor.namedefault isall-model-pods; the ama settings ConfigMap name/namespace are pinned (the add-on only reads that exact name inkube-system).