feat(helm): allow custom annotations on the default ModelConfig#2201
Open
marians wants to merge 1 commit into
Open
feat(helm): allow custom annotations on the default ModelConfig#2201marians wants to merge 1 commit into
marians wants to merge 1 commit into
Conversation
Signed-off-by: Marian Steinbach <marian@giantswarm.io>
Contributor
There was a problem hiding this comment.
Pull request overview
Adds support for specifying arbitrary Kubernetes annotations on the Helm-generated default ModelConfig (the one derived from providers[.Values.providers.default]), enabling downstream tooling/distributions to attach metadata without post-rendering or managing a separate ModelConfig.
Changes:
- Document a new optional per-provider
annotationsmap invalues.yaml. - Render
providers.<default>.annotationsundermetadata.annotationsfor the generated defaultModelConfig, omitting the block when unset.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| helm/kagent/values.yaml | Documents the new optional per-provider annotations values knob for the default ModelConfig. |
| helm/kagent/templates/modelconfig.yaml | Conditionally renders $model.annotations into metadata.annotations on the generated default ModelConfig. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
EItanya
requested changes
Jul 10, 2026
| # caCertSecretRef: "" | ||
| # caCertSecretKey: "" | ||
| # disableSystemCAs: false | ||
| # Optional annotations added to the generated default ModelConfig's metadata. |
Contributor
There was a problem hiding this comment.
Can we add this key under providers so that we can have a default annotations: {} key to show the API?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds an optional per-provider
annotationsmap that is rendered onto the metadata of the Helm-generated default ModelConfig (the one derived fromproviders.default).Why
Today
helm/kagent/templates/modelconfig.yamlemits onlyname/namespace/labels— there is no supported way to attach annotations to the default ModelConfig via values. Downstream distributions and tooling that key off resource annotations (e.g. a UI reading a display-name annotation) currently have to either post-render the chart-owned object or define a separate, self-managed ModelConfig (leaving the chart's unconditional default ModelConfig created but unused). See #2200.How
The map is generic (no vendor-specific keys) and omitted entirely when unset.
Testing
helm templateverified in two cases: withannotationsset the block renders undermetadata.annotations; without it the output is byte-identical to before (backward-compatible).Closes #2200