Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request adds a getstored method to the table classes that returns all stored values up to the filled count. The PR also refactors internal methods to use direct array access instead of the bounds-checking get method for performance, adds explicit subroutine names to end statements, and updates Makefile compiler flags to support C preprocessor directives.
Changes:
- Added
getstoredmethods to both scalar and array table types that return the filled portion of the internal storage array - Refactored
writetable,writestream, andwritehdf5methods to use directstoredarray access instead ofgetmethod calls for better performance - Added explicit subroutine names to all
end subroutinestatements in test file for clarity - Updated Makefile compiler flags to include
-fpp/-cppfor C preprocessor support and changed standard from f08 to f18
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/modtable.fypp | Added getstored method declarations and implementations for both scalar and array table types; refactored write methods to use direct array access |
| test/test_table_stream.fypp | Added test cases for the new getstored method in all test subroutines; added explicit names to end subroutine statements |
| Makefile | Updated compiler flags: added preprocessor flags (-fpp/-cpp) and changed Fortran standard from f08 to f18 for ifort |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.