Skip to content

feat(pie-icon-with-background): DSW-4171 add isDimmed state - #3089

Open
nindyahapsari wants to merge 14 commits into
mainfrom
DSW-4171-pie-icon-with-background-component-add-disabled-state
Open

feat(pie-icon-with-background): DSW-4171 add isDimmed state#3089
nindyahapsari wants to merge 14 commits into
mainfrom
DSW-4171-pie-icon-with-background-component-add-disabled-state

Conversation

@nindyahapsari

@nindyahapsari nindyahapsari commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

Describe your changes (can list changeset entries if preferable)

[Added] - isDimmed prop for pie-icon-with-background

isDimmed is a disable state that apply only visually not functionally because the icon itself is not interactive

Author Checklist (complete before requesting a review, do not delete any)

  • I have performed a self-review of my code.
  • I have added thorough tests where applicable (unit / component / visual).
  • I have reviewed the PIE Storybook/PIE Docs PR preview.
  • I have reviewed visual test updates properly before approving.
  • If changes will affect consumers of the package, I have created a changeset entry.
  • If a changeset file has been created, I have tested these changes in PIE Aperture using the /test-aperture command.

Not-applicable Checklist items


Reviewer checklists (complete before approving)

Mark items as [-] N/A if not applicable.

Reviewer 1

  • I have reviewed the PIE Storybook/PIE Docs PR preview.
  • I have verified that all acceptance criteria for this ticket have been completed.
  • [-] I have reviewed the Aperture changes (if added)
  • [-] If there are visual test updates, I have reviewed them.

Reviewer 2

  • I have reviewed the PIE Storybook/PIE Docs PR preview.
  • I have verified that all acceptance criteria for this ticket have been completed.
  • I have reviewed the Aperture changes (if added)
  • If there are visual test updates, I have reviewed them.

@changeset-bot

changeset-bot Bot commented Aug 4, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 9490aac

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
@justeattakeaway/pie-icon-with-background Minor
@justeattakeaway/pie-webc Patch
@justeattakeaway/pie-docs Patch
@justeattakeaway/pie-storybook Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Comment thread packages/components/pie-icon-with-background/src/defs.ts Outdated
Base automatically changed from DSW-4170-pie-icon-with-background-component-add-variant-is-strong-colours to main August 10, 2026 08:53
@nindyahapsari
nindyahapsari force-pushed the DSW-4171-pie-icon-with-background-component-add-disabled-state branch from 62a1922 to 84b1de4 Compare August 10, 2026 11:40
@nindyahapsari
nindyahapsari marked this pull request as ready for review August 10, 2026 11:44
@nindyahapsari
nindyahapsari requested a review from a team as a code owner August 10, 2026 11:44
@nindyahapsari nindyahapsari self-assigned this Aug 10, 2026
@pie-design-system-app
pie-design-system-app Bot temporarily deployed to storybook-testing-pr-3089 August 10, 2026 11:49 Inactive
@pie-design-system-app
pie-design-system-app Bot temporarily deployed to storybook-testing-pr-3089 August 11, 2026 10:16 Inactive
@pie-design-system-app
pie-design-system-app Bot temporarily deployed to storybook-testing-pr-3089 August 11, 2026 10:29 Inactive
@pie-design-system-app
pie-design-system-app Bot temporarily deployed to storybook-testing-pr-3089 August 11, 2026 12:37 Inactive
@nindyahapsari

Copy link
Copy Markdown
Contributor Author

/test-aperture

@pie-design-system-app

Copy link
Copy Markdown
Contributor

Starting a new snapshot build. You can view the logs here.

@nindyahapsari
nindyahapsari requested a review from raoufswe August 12, 2026 12:37
@pie-design-system-app
pie-design-system-app Bot temporarily deployed to storybook-testing-pr-3089 August 12, 2026 13:42 Inactive
ashleynolan
ashleynolan previously approved these changes Aug 12, 2026
@nindyahapsari
nindyahapsari force-pushed the DSW-4171-pie-icon-with-background-component-add-disabled-state branch from dc86d56 to 75f736f Compare August 12, 2026 14:47
@pie-design-system-app
pie-design-system-app Bot temporarily deployed to storybook-testing-pr-3089 August 12, 2026 14:54 Inactive
raoufswe
raoufswe previously approved these changes Aug 12, 2026
Comment thread packages/components/pie-icon-with-background/README.md
@pie-design-system-app

Copy link
Copy Markdown
Contributor


Fails
🚫 You have unchecked checklist items outside the "Not-applicable Checklist items" section.

Please ensure all unchecked checkboxes are moved to the appropriate section.

🚫 You have unchecked checklist items in Reviewer 2's section.

Please ensure all items are addressed before approval.

Generated by 🚫 dangerJS against 9490aac

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants