feat(pie-icon-with-background): DSW-4171 add isDimmed state - #3089
Open
nindyahapsari wants to merge 14 commits into
Open
feat(pie-icon-with-background): DSW-4171 add isDimmed state#3089nindyahapsari wants to merge 14 commits into
nindyahapsari wants to merge 14 commits into
Conversation
🦋 Changeset detectedLatest commit: 9490aac The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
pie-design-system-app
Bot
temporarily deployed
to
storybook-testing-pr-3089
August 4, 2026 13:27
Inactive
Base automatically changed from
DSW-4170-pie-icon-with-background-component-add-variant-is-strong-colours
to
main
August 10, 2026 08:53
nindyahapsari
force-pushed
the
DSW-4171-pie-icon-with-background-component-add-disabled-state
branch
from
August 10, 2026 11:40
62a1922 to
84b1de4
Compare
nindyahapsari
marked this pull request as ready for review
August 10, 2026 11:44
pie-design-system-app
Bot
temporarily deployed
to
storybook-testing-pr-3089
August 10, 2026 11:49
Inactive
…add-disabled-state
pie-design-system-app
Bot
temporarily deployed
to
storybook-testing-pr-3089
August 11, 2026 10:16
Inactive
… update docs and storybook
pie-design-system-app
Bot
temporarily deployed
to
storybook-testing-pr-3089
August 11, 2026 10:29
Inactive
…add-disabled-state
pie-design-system-app
Bot
temporarily deployed
to
storybook-testing-pr-3089
August 11, 2026 12:37
Inactive
Contributor
Author
|
/test-aperture |
Contributor
|
Starting a new snapshot build. You can view the logs here. |
pie-design-system-app
Bot
temporarily deployed
to
storybook-testing-pr-3089
August 12, 2026 13:42
Inactive
ashleynolan
previously approved these changes
Aug 12, 2026
raoufswe
reviewed
Aug 12, 2026
nindyahapsari
force-pushed
the
DSW-4171-pie-icon-with-background-component-add-disabled-state
branch
from
August 12, 2026 14:47
dc86d56 to
75f736f
Compare
…add-disabled-state
pie-design-system-app
Bot
temporarily deployed
to
storybook-testing-pr-3089
August 12, 2026 14:54
Inactive
raoufswe
previously approved these changes
Aug 12, 2026
jamieomaguire
requested changes
Aug 12, 2026
…s covered by visual tests
pie-design-system-app
Bot
temporarily deployed
to
storybook-testing-pr-3089
August 12, 2026 16:39
Inactive
pie-design-system-app
Bot
temporarily deployed
to
storybook-testing-pr-3089
August 12, 2026 17:01
Inactive
Contributor
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes (can list changeset entries if preferable)
[Added] -
isDimmedprop forpie-icon-with-backgroundisDimmed is a disable state that apply only visually not functionally because the icon itself is not interactive
Author Checklist (complete before requesting a review, do not delete any)
PIE Storybook/PIE DocsPR preview./test-aperturecommand.Not-applicable Checklist items
Reviewer checklists (complete before approving)
Mark items as
[-] N/Aif not applicable.Reviewer 1
PIE Storybook/PIE DocsPR preview.Reviewer 2
PIE Storybook/PIE DocsPR preview.