DSW-3906: textarea-uncontrolled-usage integration - #549
Open
pie-design-system-app[bot] wants to merge 5 commits into
Open
DSW-3906: textarea-uncontrolled-usage integration#549pie-design-system-app[bot] wants to merge 5 commits into
pie-design-system-app[bot] wants to merge 5 commits into
Conversation
14 tasks
pie-pr-number: 3092 pie-pr-sha: dc3b7b73550e4eb43f14d832cc60c816f4ded9cd
KatarinaNeskovic
force-pushed
the
dsw-3906-textarea-uncontrolled-usage
branch
from
August 6, 2026 13:03
6eb2617 to
0228c2f
Compare
KatarinaNeskovic
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces changes to the controlled and uncontrolled forms and account for presence of
defaultValueinpie-textarea, in order to test the expected form behavior as defined in the related PIE PR.defaultValueand form resets to that value as expected.valueas expected - in these examples that is initialised to '', which is why we see a placeholder on first render.onResethandler was added, ensuring thedescriptionstate is properly updated on form reset. The handler sets the textarea value to the provideddefaultValuewhen form resets. Without this, state was solely dependent on user input, so resetting the form left it stale - meaningdefaultValuecould not be submitted unless user typed in again.