Conversation
|
|
Member
Author
|
Hmm, so right now if the file is already open it does not reflect the edit mode changes |
Member
Author
|
For quick look up: Screen.Recording.2026-05-30.at.3.54.24.AM.mov |
Member
Author
|
So earlier, when we had unsaved changes, and we used the edit mode to make changes in the same file with unsaved changes, it overwrote the changes. I feel this is maybe not something a user would want ( to lose their changes ). So, we have now added a notification Screen.Recording.2026-05-30.at.5.13.12.AM.mov |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1464
This change adds inline editing support for WORKING vs HEAD plain text diffs and keeps the UX stable by saving edits with a 1-second debounce, refreshing diff content safely, and restoring cursor/focus after refresh. It also adds focused tests for edit button visibility, save behavior, safe refresh handling, selection restoration, and dispose-time save to ensure the flow is deterministic and reliable.