Skip to content

fix: correct login error body read, add HTTP timeout, validate exclusive flags - #2

Open
o5carm wants to merge 2 commits into
juli3nk:developfrom
o5carm:fix/bugs-rebased
Open

o5carm wants to merge 2 commits into
juli3nk:developfrom
o5carm:fix/bugs-rebased

Conversation

@o5carm

@o5carm o5carm commented Aug 24, 2026

Copy link
Copy Markdown

Fixes

  • pkg/simplelogin/auth.go:

    • Add 30s timeout to HTTP client (was unbounded)
    • Use io.ReadAll instead of json.Marshal(resp.Body) to correctly read error response body
  • command/alias/list.go:

    • Mark --pinned/--disabled/--enabled as mutually exclusive

Rebased on develop branch.

juli3nk and others added 2 commits August 24, 2026 08:37
…ive flags

- pkg/simplelogin/auth.go: add 30s timeout to HTTP client
- pkg/simplelogin/auth.go: use io.ReadAll instead of json.Marshal(resp.Body)
  to correctly read error response body
- command/alias/list.go: mark --pinned/--disabled/--enabled as mutually exclusive
@juli3nk
juli3nk force-pushed the develop branch 3 times, most recently from 85e76e9 to df08c71 Compare August 29, 2026 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants