Repository navigation
Conversation
…atching bandwidth or validity period
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously whenever a part of an asset was bought, the old asset was deleted and a new asset was created with all remaining bandwidth (if any was left), one was created with the same bandwidth that was bought with the validity period to the left, and one with the validity period to the right of the bought asset. This led very fast to a huge number of assets which also made it much more difficult for a client to query and find the assets it actually needed.
With this PR, the database no longer deletes the old asset or creates new assets for the remainders, only intervals mapping to the same asset. That way the users can still buy from the asset using the original ID, even if in the meantime another user came and also bought from the same asset (given there is still enough bandwidth available) and disk consumption for the database is reduced since for all validity intervals we only store (asset_id, starts_at, stops_at and available), instead of the full asset information, since that information is referenced by the asset_id.
The Search Assets endpoint has been modified to allow for different search modes:
The Update Assets endpoint had to be modified to ensure compatability with the changes above. Since now we no longer create new assets out of the remainders, certain asset modifications are no longer allowed. The changes that are still allowed are:
All those changes do not affect already sold parts of the asset.
TODO:
This change is