Repository navigation
fix: automate upstream sync bookkeeping and date released changelog sections - #20
Merged
Merged
Conversation
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 59 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upstream syncs need manual bookkeeping today, and every version change breaks CI. This PR removes both problems so the sync workflow can open a PR that passes CI on its own. It also repairs What's New for the 0.9.3.1 and 0.9.5.1 releases.
Changes
startup_overlays.rshard-codedv0.9.5.1andSUPERHERDR 0.9.1.2, andhistory_omits_unreleased_sectionsrequired the live CHANGELOG to contain an Unreleased section. Both now derive their expectations from the running version or from a synthetic changelog.full_history_body_from()exists for that purpose.### Inherited from Herdrsection to match the Cargo base version. The other requires the current Superherdr version's heading to be dated. CONTRIBUTING has always said the first one was enforced, but no test checked it.## [0.9.5.2] - Unreleasedwith the installer and What's New fixes.releases/latest/download/install.shinstead of the 0.9.0.1 installer.scripts/sync_upstream.shnow resolves the conflicts that come with every upstream release. Anything else still exits 2 and produces a draft PR. The new steps:cargo update --workspace.SUPERHERDR_REVISIONto 1.CHANGELOG.md, which also covers skipped releases.## [<base>.1]section. A pending Unreleased section becomes that section, and the intro text above it is kept.versionfollows upstream, and the fourth part comes fromSUPERHERDR_REVISION.No OpenSpec proposal: these changes restore behavior the baseline specs already require, the release-notes order and the installer default.
Evidence
RUSTUP_TOOLCHAIN=1.96.1 just checkon this branch merged withci/automated-releases: exit 0. nextest ran 4185 tests, 4185 passed and 16 were skipped. OpenSpec: 6 passed, 0 failed.python3 -m unittest scripts.test_sync_upstream -v: 9 tests OK. The new intro-preservation assertion fails against the previous script and passes with the fix.Replayed the v0.9.5 sync from
ebe0ca62(main before 0.9.5) in a scratch worktree:Cargo.tomland thesuperherdrlock entry match9378c4b2.## [0.9.5.1] - <date>.cargo metadata --lockedsucceeds.The replay also found a SIGPIPE exit 141 under
pipefailthat the small fixtures could not trigger. It is fixed.grep -rn '0\.9\.5\.1\|0\.9\.1\.2' src: no hits.Merge this before
ci/automated-releases: its publish gate requires the dated heading format this PR writes.