[P1] Use semantic key identity in borrowed Node merges - #87
Draft
jskoiz wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
&Nodemerge expansion usesame_key_identity, matching the owned merge path and ignoring source spans/source metadata.from_node, borrowed&Node, and ownedNodedeserialization. The tests preserve explicit/local-key precedence.Verification
Local proof:
git diff --check— passed.cargo fmt --all --check— passed.cargo test --locked --test serde_value_api serde_api_borrowed_node_merge_uses_semantic_key_identity.No space left on device (os error 28). Per the task handoff, no further Cargo builds were started.Hosted/merge state:
c1/issue-76-borrowed-merge-identity.main; CI run32536800326has six Rust/audit jobs in progress, and GitGuardian is successful.Notes/Risks