Skip to content

fix: correct HTTP target parsing - #205

Merged
MartinKolarik merged 3 commits into
masterfrom
update-target-parsing
Oct 5, 2026
Merged

MartinKolarik merged 3 commits into
masterfrom
update-target-parsing

Conversation

@PavelKopecky

@PavelKopecky PavelKopecky commented Oct 5, 2026 •

Copy link
Copy Markdown
Contributor

Addresses jsdelivr/globalping.io#203 (comment)

Percent-encoded URL paths are no longer decoded before creating HTTP measurements. For example, /a%2Fb now requests /a%2Fb instead of /a/b; use /a/b explicitly to retain the previous request path. IPv6 URL hosts must be bracketed. Bare IPv6 addresses can now be used directly as targets

@coderabbitai

coderabbitai Bot commented Oct 5, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: CHILL
  • Plan: Essentials
  • Run ID: 734f3da8-14ff-45eb-9ed2-3e11a12cabff
📥 Commits

Reviewing files that changed from the base of the PR and between f026226 and bc1d012.

📒 Files selected for processing (5)
  • cmd/common.go
  • cmd/common_test.go
  • cmd/http.go
  • cmd/http_test.go
  • cmd/table_test.go

Included review availability: This review used your included allowance. 3 included reviews remain after this review. Your included PR review attempts over the past 7 days set your current allowance at 5 reviews per hour.


Walkthrough

HTTP target parsing now supports HTTP/2 URLs, bare IP addresses, and escaped paths. IPv6 URL hosts must be bracketed. Measurement request construction and IP-target detection use the updated parser. The exported UrlData type is replaced by the unexported httpTargetData type. Tests cover parsed targets, request construction, encoded values, and explicit overrides.

Suggested reviewers: martinkolarik

Priority: ➖ Normal

Merge Risk: ⚪ Minimal · up to bc1d0

The changed request path preserves encoded slashes as intended. No actionable merge-blocking risk remains after normal checks.

🚥 Pre-merge checks | ✅ 4
✅ Passed checks (4 passed)
Check name Status Explanation
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed The title clearly describes the main change: correcting HTTP target parsing.
Description check ✅ Passed The description covers the changes to percent-encoded paths and IPv6 target parsing.
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@MartinKolarik MartinKolarik changed the title fix!: correct HTTP target parsing fix: correct HTTP target parsing Oct 5, 2026
@MartinKolarik
MartinKolarik merged commit 24d357e into master Oct 5, 2026
9 checks passed
@MartinKolarik
MartinKolarik deleted the update-target-parsing branch October 5, 2026 12:56
@github-actions

github-actions Bot commented Oct 6, 2026

Copy link
Copy Markdown

🎉 This PR is included in version 1.6.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants