Repository navigation
Apply the simple-rust audit: fmt, clippy -D warnings, typed errors - #62
Merged
Merged
Conversation
…rrors, params struct
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Applies the simple-rust skill (now saved as a project skill) across the codebase. Verified end state: cargo fmt --check clean, cargo clippy --all-targets -- -D warnings clean, full cargo test suite green. Independent of #61 (disjoint files; merge in any order).
Formatting: the tree was never rustfmt-formatted (360 diff hunks). This PR runs cargo fmt over everything; most of the diff is that mechanical pass.
Semantic changes:
Deliberately unchanged (local convention wins over the guide): mod.rs module layout throughout; update_bookmark keeps 7 positional args (at, not over, the clippy threshold); grouped db/service layering as-is. Suggestion for later (needs workflow-edit permission the Muse app token lacks): a CI job running fmt --check + clippy -D warnings + test so the gates stay green.