Repository navigation
Add PWA basics: viewport, theme-color, and web app manifest - #59
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PWA basics for brunnylol, so the site installs and lays out properly on mobile:
base.html) and on the themed error pages (src/error.rs) — mobile browsers were guessing the layout width without it.#1a1a2e, the site's--bg-primary) in both places too, so browser chrome matches the theme.static/manifest.json(name/short_name Brunnylol,start_url: /,display: standalone, brand colors), linked frombase.html.static/favicon.svg, traveling base64-encoded underassets/and decoded intostatic/bybuild.rs— the same pattern as the existing favicon PNGs (which is why they're gitignored as generated files). The manifest also references the existing 180×180 apple-touch icon.Tests: new
tests/pwa_test.rs— the manifest is served as JSON and parses with the expected fields, every icon it references is actually served as image/png (this also proves build.rs regenerated the 192/512 PNGs from a cold tree), and the home page carries the viewport meta, theme-color, and manifest link. The existing favicon suite still passes.