Repository navigation
Fix favicon.svg: double hyphen in XML comment breaks Firefox - #57
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The favicon did not render in Firefox. Opening the SVG showed XML Parsing Error: not well-formed, line 4, column 11 — reproduced against the production file with a parser (same line/column).
Cause: the header comment in
static/favicon.svgquoted the CSS variable names--gradient-start/--gradient-end. XML comments may not contain a double hyphen (--); Chrome's lenient parser tolerated it and rendered the icon, Firefox's strict XML parser rejects the entire document, so Firefox fell back to no icon. The PNG icons were unaffected (which is why the Android shortcut looked fine).Fix: reworded the comment to drop the double hyphens (and left a note in the comment itself so it doesn't come back). Artwork is byte-identical apart from the comment text — no visual change, and the generated PNGs did not need regeneration.
Regression guard:
tests/favicon_test.rsnow asserts that no XML comment in the served SVG contains--. Verified the guard flags the old production file and passes on the fixed one; the fixed file parses cleanly as well-formed XML.