Repository navigation
feat(forms): translatable DatePicker, DateInput and Calendar labels - #623
Merged
josemarluedke merged 2 commits intoOct 16, 2026
Merged
Conversation
The date components' own text was hard-coded English: the clear button,
the calendar button ("Choose date, <label>"), and the calendar's
previous/next buttons, month select and year grid. `@labels` overrides
any of them; whatever is left out keeps today's default, so nothing
changes for existing users.
- Calendar: `previousMonth`, `nextMonth`, `month`, `year`.
- DateInput: `clear`.
- DatePicker: `clear`, `chooseDate` and the calendar's four, handed on to
its calendar and to a `:calendar` block. `chooseDate` is a function of
the field's `@label`, since some languages put it elsewhere in the
sentence.
The segments' names stay `@segmentLabels`.
Closes josemarluedke#622
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
✅ Deploy Preview for frontile-next ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
It is 33 lines, over the 30-line limit the site's code-block policy test enforces for preview fences. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
josemarluedke
approved these changes
Oct 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #622.
DatePicker,DateInputandCalendarhard-coded the English text thatIntland@segmentLabelsdon't cover, so a translated date field still announced "Choose date", "Clear" and "Next month". This adds@labelsto all three, the same shape asPagination's (#619): override any of the texts below, and whatever you leave out keeps today's default. Nothing changes for existing users.previousMonthPrevious montharia-labelnextMonthNext montharia-labelmonthMonth<select>aria-label(@captionLayout="dropdown")yearYeararia-label(@captionLayout="dropdown")clearClear@isClearable)chooseDate(label) => label ? `Choose date, ${label}` : 'Choose date'aria-label(segmented field)chooseDateis a function of the field's@labelbecause some languages put it elsewhere in the sentence.DatePickerhands@labelsto its calendar as it is, and passes it in the:calendarblock's args, so a custom calendar can use it too. The types are exported asCalendarLabels,DateInputLabelsandDatePickerLabels.Changes
CalendarLabelswith the English defaults, merged with@labelsand passed to the header and the year grid, which read theiraria-labels from it.DateInputLabels(clear).DatePickerLabels(CalendarLabelsplusclearandchooseDate). The end content gets the finished strings rather than building"Choose date, " + labelitself.DatePickerCalendarArgsgainslabels.clearoverridden; the default.labelsreaching a:calendarblock.Checks
eslint,prettier --checkandember-tsc --noEmit(frontile) pass.lint:hbs, test-app'slint:typesandlint:anatomyfail identically onmain(90 template-lint errors; TS 6'sbaseUrldeprecation; the same 8 date-input/date-picker anatomy findings). Nothing new from this branch.🤖 Generated with Claude Code