Skip to content

[WIP] Tooltips indicating the kind of error - #213

Open
gstark0 wants to merge 5 commits into
jonorthwash:masterfrom
gstark0:warnings
Open

[WIP] Tooltips indicating the kind of error#213
gstark0 wants to merge 5 commits into
jonorthwash:masterfrom
gstark0:warnings

Conversation

@gstark0

@gstark0 gstark0 commented Jan 11, 2018

Copy link
Copy Markdown
Contributor

[Work In Progress]
Currently added warning icon to graph that indicates if there is any error with deprel.

Update: I integrated Qtip with Cytoscape to display warnings :) Unfortunately, Cytoscape does not allow for too many custom added features :(

@ftyers @maryszmary Let me know what you think.

screen shot 2018-01-11 at 20 21 21

screen shot 2018-01-11 at 18 56 11

@gstark0 gstark0 changed the title [WIP] Warning icon if error [WIP] Tooltips indicating the kind of error Jan 11, 2018
@ftyers

ftyers commented Jan 12, 2018

Copy link
Copy Markdown
Collaborator

@gstark0 can you fix the style/formatting to make it look good with the rest of the interface ?

@gstark0

gstark0 commented Jan 12, 2018

Copy link
Copy Markdown
Contributor Author

@ftyers How about this design? I chose the colors to match the toolbar at the top.
screen shot 2018-01-12 at 15 59 35
screen shot 2018-01-12 at 15 59 00

@ftyers

ftyers commented Jan 12, 2018

Copy link
Copy Markdown
Collaborator

Looks better... and it only appears when you hover over the warning sign right?

@gstark0

gstark0 commented Jan 12, 2018

Copy link
Copy Markdown
Contributor Author

@ftyers Nope... yet. That's the whole problem here, Cytoscape doesn't support label events (I read somewhere it's because of performance), I'm still figuring out how to handle this :< I also asked question about this, no answer yet. Right now it's on arc hover :(

@ftyers

ftyers commented Jan 12, 2018

Copy link
Copy Markdown
Collaborator

@gstark0 ok, let's pause this one until we get an answer. :)

@gstark0

gstark0 commented Jan 12, 2018

Copy link
Copy Markdown
Contributor Author

@ftyers Okay, I will try to figure out something myself meanwhile.

@gstark0

gstark0 commented Jan 12, 2018

Copy link
Copy Markdown
Contributor Author

Btw, should this also appear when cycle is detected?

@ftyers

ftyers commented Jan 12, 2018

Copy link
Copy Markdown
Collaborator

Yeah, but in that case maybe it would be nice to have it nearer the arc than the label.

@gstark0

gstark0 commented Jan 12, 2018

Copy link
Copy Markdown
Contributor Author

@ftyers Okay. How about some alternative solutions for the hover issue, maybe removing the icon (or placing it before label, like left arrow), tooltip can appear on arc hover then, and can be dismissed by just clicking anywhere inside the tooltip(could be highlighted) or button inside tooltip?

@gstark0

gstark0 commented Jan 12, 2018

Copy link
Copy Markdown
Contributor Author

@ftyers Take a look at this video I made(converted to gif, its pretty slow :<), it shows how this works now. I know it's not what you wanted, but it's as close as I could get right now. I went through the documentation of Cytoscape, but haven't found anything that would suit this issue, seems like not possible without modifying Cytoscape's code (although I'm still waiting for the answer on stackoverflow). It's not that intuitive unfortunately, as it could be with hover over icon :<
EDIT: I found library, which was creating HTML labels for Cytoscape(which I could possibly attach to Qtip), but when I integrated it with Annotatrix, it was slow as hell, not to mention a lot of bugs :(
ud2

@jonorthwash
jonorthwash force-pushed the master branch 7 times, most recently from c8c83a7 to b6180dc Compare June 11, 2021 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants