Repository navigation
Conversation
The Node shell's guarded fetch only had an inactivity timeout, so an
upstream sending a byte every few seconds could hold a socket open forever.
Add a 120 s deadline over the whole exchange; after the response starts it
destroys the body stream, so the reason ("deadline timeout") reaches the
core's log and its timeout classification.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
✅ Deploy Preview for savrlist ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #125 (#124), from its code review.
The Node shell's guarded fetch had only an inactivity timeout (30 s). An upstream that sends a byte every few seconds never goes idle, so it could hold a socket, and the waiting client, open indefinitely.
Change
createGuardedFetchtakes a newdeadlineMsoption, defaulting to 120 s, covering the whole exchange from request to the end of the body.upstream deadline timeout) reaches the reader, and core files it under its existingtimeouterror kind, instead of a genericaborted.unref'd.infra/cors-worker/README.mddocuments both timeouts.Tests
guarded-fetch.test.mjs:node --testininfra/cors-worker: 103/103.The Cloudflare shell is unaffected.
🤖 Generated with Claude Code