Repository navigation
Add a Justfile; CI unit-test steps call its recipes - #126
Merged
Merged
Conversation
App recipes delegate to package.json scripts. The worker, extension and web-ext checks that only lived in CI become recipes, plus the two wrangler deploys. `just ci` runs the same steps as the unit-tests CI job, which now calls each recipe (via extractions/setup-just), so local and CI can't drift. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
✅ Deploy Preview for savrlist ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a repo-root
Justfileso the common commands live in one place.dev,build,lint,test,e2e) delegate to thepackage.jsonscripts, so nothing is duplicated.test-workers,test-extension,lint-extension,typecheck). So do the two wrangler deploys (deploy-proxy,deploy-proxy-public), which are easy to mix up.just ciruns the same steps, in the same order, as theunit-testsCI job.unit-testsjob now calls its recipe, installed viaextractions/setup-just@v4. The steps keep their names, so it stays clear which step failed, and local runs and CI can't drift apart. The e2e job is unchanged.README.mdanddocs/DEVELOPMENT.mdpoint at the Justfile.justis not added to the FloxHub env in this PR. Runningflox install justalso migrated the manifest schema, and that would need aflox pushto the shared remote env.Verification:
just cipasses locally (lint: 0 errors; jest: 472/472; worker and extension tests; web-ext: 0 errors).The
proxy-uprecipe for the self-hosted CORS proxy belongs with #125, which adds the compose service.🤖 Generated with Claude Code