image-dump-example: write todos.jimg to the project dir, not the cwd - #26
Open
yogthos wants to merge 1 commit into
Open
image-dump-example: write todos.jimg to the project dir, not the cwd#26yogthos wants to merge 1 commit into
yogthos wants to merge 1 commit into
Conversation
The dev launcher (jolt/bin/jolt) cd's to the jolt checkout so the runtime's relative loads resolve, passing the original directory as JOLT_PWD -- a bare relative image path lands in the jolt repo there. Resolve against JOLT_PWD like jolt.main does for deps.edn; the release binary has no cd and no JOLT_PWD, so "." stays correct.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Under the dev launcher (
jolt/bin/jolt), the process cwd is the jolt checkout(the launcher cd's there so the runtime's relative loads work, stashing the
project dir in
JOLT_PWD). A bare"todos.jimg"therefore lands in the joltrepo instead of the example project — which is exactly where a stray one turned
up during testing.
Resolve the path against
JOLT_PWDthe same wayjolt.mainresolvesdeps.edn. The release binary runs without the cd and withoutJOLT_PWD, sothe
"."fallback keeps today's behavior there.Verified under
bin/joltfrom the example dir: the file is written to theproject dir and not the jolt checkout.