ring-app: pin the time and db shas with the declare fixes - #22
Merged
Conversation
added 2 commits
July 29, 2026 12:06
jolt now reports an unresolved symbol at compile time wherever it appears, like Clojure does, and both libraries had a var referenced before its defn: jolt.time.zoned's odt, jolt.time.fmt's parse-with-pattern, and jdbc.core's pgfn. Each has a declare now. The time bump also moves off the old lineage, whose jolt.time.impl/util/local duplicated the java.time base that jolt ships in stdlib.
jolt-lang/time#3 landed as a squash, so the sha this branch pinned is not on main; point both deps at the commits the new tags name instead — time v0.0.3 (70dfb79) and db v0.0.2 (f368b12).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
jolt build -m app.corecould not build this example. The chain was four bugs injolt (jolt-lang/jolt#494) plus a forward reference in each of two libraries:
jolt.time.zoned calls
odtand jolt.time.fmt callsparse-with-patternbeforetheir
defn, and jdbc.core callspgfnbefore its. jolt now reports anunresolved symbol at compile time wherever it appears, like Clojure always has,
so each needs the
declarethat made the pattern legal.This pins the two library commits that add them:
33bb3f069dd133f8293f98ee334de3e18b0545f683edbee67cfb416e21e9176f298e48363ab41d45The time bump also moves off the old lineage, which shipped its own
jolt.time.impl / util / local — duplicates of the java.time base jolt now has in
stdlib.
With jolt-lang/jolt#494 and these two,
jolt build -m app.coreproduces a binarythat serves the guestbook: GET / is 200, POST /sign is 303 and the entry comes
back on the next render. Merge the two library PRs first, since the shas above
are their heads.