Skip to content

⚡ Optimize SynchronizedCollection.Get allocations #89

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
johnstrand merged 2 commits into from
Jul 20, 2026
Merged

⚡ Optimize SynchronizedCollection.Get allocations #89

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b2fdde3
Optimize SynchronizedCollection.Get to cache the snapshot and elimina…
google-labs-jules[bot] Jul 17, 2026
db0ade2
Merge branch 'master' into perf-synchronizedcollection-get-1606328776…
johnstrand Jul 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 16 additions & 1 deletion src/GameUtils/Types/Collections/SynchronizedCollection.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,8 @@ public abstract class SynchronizedCollection<T> : IEnumerable<T> where T : notnu
{
private readonly ConcurrentQueue<Operation<T>> _pending = new();
private readonly SemaphoreSlim _integrating = new(1, 1);
private IReadOnlyList<T>? _cachedSnapshot;
private bool _dirty = true;

/// <summary>
/// Schedules an entity to be added to the collection.
Expand All @@ -57,9 +59,16 @@ public void Integrate()
_integrating.Wait();
try
{
bool modified = false;
while (_pending.TryDequeue(out var operation))
{
HandleOperation(operation);
modified = true;
}

if (modified)
{
_dirty = true;
}
}
finally
Expand Down Expand Up @@ -101,7 +110,13 @@ public IEnumerable<T> Get()
_integrating.Wait();
try
{
return GetInternal().ToList();
if (_dirty || _cachedSnapshot is null)
{
_cachedSnapshot = GetInternal().ToList();
_dirty = false;
}

return _cachedSnapshot;
}
finally
{
Expand Down
Loading