Repository navigation
fix: accept valid quarter-hour profile UTC offsets - #203
Merged
Merged
Conversation
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Saving profile job preferences rejected valid UTC offsets such as
3,5.5, and5.75. The existing divisibility validator truncates the divisor0.25to zero, so every supplied numeric offset failed validation.Replace it with a shared quarter-hour check using integer quarter-hours. Keep the existing numeric validation and -12 to +14 bounds, and provide a clear error for unsupported increments.
Validation: reproduced 109 failures before the fix; all 200 profile tests now pass, including every allowed quarter-hour offset, numeric strings, unset values, invalid increments, and bounds through the production request validation settings. Production build and changed-file lint pass.