-
Notifications
You must be signed in to change notification settings - Fork 154
One condition is shown but another is applied in GenericFilter #5634
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
fractal3000
merged 5 commits into
release_3_0
from
bug/5516-one-condition-is-shown-but-another-is-applied-in-generic-filter
Sep 7, 2026
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
0bc7b80
Recompose the loader condition on apply and on the Apply button so a …
bbbe357
Recompose the loader condition before a delegated condition's direct …
12890bb
Replace the owner traversal with a recomposition delegate
4155278
Tighten the recomposition delegate after a quality pass
it-school-admin 129fa8d
Wire the recomposition delegate at configuration adoption
it-school-admin File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
62 changes: 62 additions & 0 deletions
62
...lowui/flowui/src/test/groovy/component/genericfilter/DataGridHeaderFilterApplyTest.groovy
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,62 @@ | ||
| /* | ||
| * Copyright 2026 Haulmont. | ||
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| package component.genericfilter | ||
|
|
||
| import facet.url_query_parameters.view.DataGridFilterUrlQueryParamsTestView | ||
| import io.jmix.flowui.component.grid.DataGridColumn | ||
| import io.jmix.flowui.component.grid.headerfilter.DataGridHeaderFilter | ||
| import io.jmix.flowui.model.CollectionLoader | ||
| import org.springframework.boot.test.context.SpringBootTest | ||
| import test_support.spec.FlowuiTestSpecification | ||
|
|
||
| /** | ||
| * Pins that {@code DataGridHeaderFilter} is not affected by the loader condition recomposition | ||
| * introduced for delegated filter conditions: its inner {@code PropertyFilter} is neither delegated | ||
| * nor given a recomposition delegate, and {@code DataGridHeaderFilter.apply()} performs exactly one | ||
| * load without replacing the loader condition object. | ||
| */ | ||
| @SpringBootTest | ||
| class DataGridHeaderFilterApplyTest extends FlowuiTestSpecification { | ||
|
|
||
| @Override | ||
| void setup() { | ||
| registerViewBasePackages("facet.url_query_parameters", "io.jmix.flowui.app") | ||
| } | ||
|
|
||
| def "a header filter is outside the recomposition wiring and its apply() loads exactly once"() { | ||
| given: "a data grid with a filterable column" | ||
| def view = navigateToView(DataGridFilterUrlQueryParamsTestView) | ||
| def column = view.ownersTable.getColumnByKey("name") as DataGridColumn<?> | ||
| def headerFilter = column.getHeaderComponent() as DataGridHeaderFilter | ||
|
|
||
| expect: "the inner property filter is neither delegated nor wired to an owner" | ||
| !headerFilter.propertyFilter.conditionModificationDelegated | ||
| headerFilter.propertyFilter.loaderConditionRecomposeDelegate == null | ||
|
|
||
| when: "the user applies the header filter" | ||
| def loader = headerFilter.propertyFilter.dataLoader as CollectionLoader | ||
| def conditionBefore = loader.condition | ||
| int loads = 0 | ||
| loader.addPostLoadListener { loads++ } | ||
| headerFilter.propertyFilter.setValue("John") | ||
| headerFilter.apply() | ||
|
|
||
| then: "exactly one load, and the loader condition object is not replaced by any recomposition" | ||
| loads == 1 | ||
| loader.condition.is(conditionBefore) | ||
| } | ||
| } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.