Repository navigation
PSR12 compatibility #137
Description
There are a lot of warnings errors seen if we launch JED checker
Ther are also warnings seen if we launch phpcs --
Metadata
Metadata
Assignees
Labels
No labels
{{ message }}
There are a lot of warnings errors seen if we launch JED checker
Ther are also warnings seen if we launch phpcs --
Activity
fix partially issue jmcameron#137 : use white spaces instead of tabs
fix partially issue jmcameron#137 : use white spaces instead of tabs
yild commentedon Jun 28, 2025
uhh... I was curious whats those red 'circles' ware... some of them are those that I mentioned in #133 (comment)
I'm more concern with
so extension name should drop "for Joomla..." to be compliant with JED rules.
and this is 'just' first row... ;)
Fix jmcameron#137 partially
JLTRY commentedon Jun 29, 2025
Still issues in phpcs
phpcs_attachments_2.txt
JLTRY commentedon Jun 29, 2025
It will be a long run task to fix all errors
yild commentedon Jul 1, 2025
You don't have to make all fixes in one go
JLTRY commentedon Jul 1, 2025
Don't worry I am quite at 2/3 of fixes
I have got time.
I start my retirement today !!!
I will publish then a pre release to be able to test
Fix jmcameron#137 partially
JLTRY commentedon Jul 2, 2025
All warnings for admin admin site normally fixed
directory test excluded
phpcs --standard=PSR12 --ignore=test . > phpcs_attachments_3.txtphpcs_attachments_3.txt
fix partially jmcameron#137
fix partially jmcameron#137
JLTRY commentedon Jul 2, 2025
remaining issues are due to bad implementation of plugins
phpcs_attachments_4.txt
fix partially jmcameron#137
JLTRY commentedon Jul 2, 2025
I delivered a pre release to be able to test
I had an internal server error
All plugins are installing
Only components fails to install . I will investigate
parapente commentedon Jul 5, 2025
Those were very simple plugins that I didn't bother to transform to the new plugin system. I will try to convert them as they will probably cause issues when joomla 6 arrives.
parapente commentedon Jul 5, 2025
@JLTRY you should get no errors now.
Merge pull request #138 from JLTRY/master