Skip to content

Wrong variables names #125

Closed
Closed

Description

@yild

Reffering to lines

$ports = 443;
}
elseif ( $protocol == 'ftp' ) {
$ports = 21;

Variable should be $port not $ports.

  • found this working on another PR.

Also, code for URL validation might be outdated by technology/security progress, i.e. cant validate URL for release file https://github.com/jmcameron/attachments/releases/download/v4.1.2/attachments-4.1.2.zip

Activity

  1. changed the title [-]Wrong varianbles names[/-] [+]Wrong variables names[/+] on Jun 19, 2025
  2. added 2 commits that reference this issue on Jun 20, 2025
  3. JLTRY commented on Jun 20, 2025

    @JLTRY
    Collaborator

    I will close the Issue and open an other one for point 2
    Also, code for URL validation might be outdated by technology/security progress, i.e. cant validate URL for release file https://github.com/jmcameron/attachments/releases/download/v4.1.2/attachments-4.1.2.zip

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions