Reffering to lines https://github.com/jmcameron/attachments/blob/53ee9fd621155130c8e04810cb597fc93fb6b482/attachments_component/site/src/Helper/AttachmentsHelper.php#L1011-L1014 Variable should be $port not $ports. - found this working on another PR. Also, code for URL validation might be outdated by technology/security progress, i.e. cant validate URL for release file https://github.com/jmcameron/attachments/releases/download/v4.1.2/attachments-4.1.2.zip
Activity
[-]Wrong varianbles names[/-][+]Wrong variables names[/+]Fix issue jmcameron#125
Merge pull request #127 from JLTRY/issue_125
JLTRY commentedon Jun 20, 2025
I will close the Issue and open an other one for point 2
Also, code for URL validation might be outdated by technology/security progress, i.e. cant validate URL for release file https://github.com/jmcameron/attachments/releases/download/v4.1.2/attachments-4.1.2.zip