Conversation
* Closes rero/rero-ils#3618. Co-Authored-by: Bertrand Zuchuat <bertrand.zuchuat@rero.ch>
To avoid redirection if the default settings are not present, they are added directly to the menu items. Co-Authored-by: Bertrand Zuchuat <bertrand.zuchuat@rero.ch>
Co-Authored-by: Bertrand Zuchuat <bertrand.zuchuat@rero.ch>
* Needs rero-ils:#3616 Co-Authored-by: Peter Weber <peter.weber@rero.ch>
* Requested by clients in RT738. * Also fixes some facets inconsistencies in items, fees and loans searches. Co-Authored-by: Pascal Repond <pascal.repond@rero.ch>
The language facet was not translated correctly, as the key starts with `lang_'. Co-Authored-by: Bertrand Zuchuat <bertrand.zuchuat@rero.ch>
When we cancel a request, if another request is active on the item, an additional message is added to the dialog. * Closes rero/rero-ils#3571. Co-Authored-by: Bertrand Zuchuat <bertrand.zuchuat@rero.ch>
The "remove_archived" parameter is used to filter the list of results. * Closes rero/rero-ils#3527. Co-Authored-by: Bertrand Zuchuat <bertrand.zuchuat@rero.ch>
During a check-in, if the item is in a collection and at a temporary location, and if the item belongs to the current library, this information is added to the message intended for the professional. * Closes rero/rero-ils#1321. Co-Authored-by: Bertrand Zuchuat <bertrand.zuchuat@rero.ch>
* Adds fees on item detail view. * Changes patron link on fees brief view to redirect to the patron circulation fees tab. * Closes rero/rero-ils#3578. Co-Authored-by: Bertrand Zuchuat <bertrand.zuchuat@rero.ch>
Access to the resource was limited to the current organisation. This protects sensitive data on professional view. Co-Authored-by: Bertrand Zuchuat <bertrand.zuchuat@rero.ch>
* Fixes the options with the new formly configuration structure. Co-Authored-by: Bertrand Zuchuat <bertrand.zuchuat@rero.ch>
* Adds owning_library key to translate library name on filter name translation service. Co-Authored-by: Bertrand Zuchuat <bertrand.zuchuat@rero.ch>
Co-Authored-by: Bertrand Zuchuat <bertrand.zuchuat@rero.ch>
Translate-URL: https://hosted.weblate.org/projects/rero_plus/ Co-Authored-by: Pascal Repond <pascal.repond@rero.ch> Co-authored-by: Hosted Weblate <hosted@weblate.org> Co-authored-by: LievenSmets <lievensmets@me.com>
Co-Authored-by: Pascal Repond <pascal.repond@rero.ch>
Co-Authored-by: Bertrand Zuchuat <bertrand.zuchuat@rero.ch>
If the size of the query exceeds 1024 characters, we truncate the identifiers and display a warning message to the user. * Closes rero/rero-ils#3118. Co-Authored-by: Bertrand Zuchuat <bertrand.zuchuat@rero.ch>
Co-Authored-by: Pascal Repond <pascal.repond@rero.ch>
* Adds the file list in the document detailed view using primeng. * Adds "search in fulltext" button in the professionnal and public view. * Changes the html page title for the document holding files view. Co-Authored-by: Johnny Mariéthoz <Johnny.Mariethoz@rero.ch>
* Adds files list and file uploads on the professionnal views. * Adds icons depending of the mime types. * Removes useless console.log. * Updates editor configuration preferences. Co-Authored-by: Johnny Mariéthoz <Johnny.Mariethoz@rero.ch>
* Removes useless console.log. * Adds a collection editor in the document detailed view. Co-Authored-by: Johnny Mariéthoz <Johnny.Mariethoz@rero.ch>
* Adds a button to preview the file before uploads. Co-Authored-by: Johnny Mariéthoz <Johnny.Mariethoz@rero.ch>
* Uses primeng bootstra4 theme to avoid layout problems. * Adds a custom pager for the the files carousel. * Adds an input to filter the files in the carousel. * Makes the carousel reponsive. * Disable the "File" tab for harvested records. * Make the carousel item clickable for the preview. * Adds permalinks collections. Co-Authored-by: Johnny Mariéthoz <Johnny.Mariethoz@rero.ch>
* Updates primeng dependency. * Creates a specific upload files components. * Adds loading wheels. Co-Authored-by: Johnny Mariéthoz <Johnny.Mariethoz@rero.ch>
* Fixes typeahead value deletion. * Fixes refresh label value on typeahead after insert. * Updates dependencies. * Closes rero/rero-ils#3661. Co-Authored-by: Bertrand Zuchuat <bertrand.zuchuat@rero.ch> Co-Authored-by: Johnny Mariéthoz <johnny.mariethoz@rero.ch>
* Needs rero-ils:#3678 Co-Authored-by: Peter Weber <peter.weber@rero.ch>
Translate-URL: https://hosted.weblate.org/projects/rero_plus/ Co-Authored-by: Pascal Repond <pascal.repond@rero.ch> Co-authored-by: gallegonovato <fran-carro@hotmail.es>
Co-Authored-by: Bertrand Zuchuat <bertrand.zuchuat@rero.ch>
There was an extra whitespace in the holdings query for displaying items-holdings in the document detailed view, which lead to items being displayed where they should not (if the holdings pid corresponded to the document pid). Co-Authored-by: Pascal Repond <pascal.repond@rero.ch>
The warning flag was incorrectly hardcoded to true instead of being retrieved from the dynamicDialogConfig data object. The warning for "too many identifiers" was then always displayed. Co-Authored-by: Pascal Repond <pascal.repond@rero.ch>
Fixes two issues in the other-edition component:
- Use flex layout (30% label width) to match description-zone alignment
- Generate correct URLs for public view (/{viewcode}/documents/{pid})
instead of admin routes (/records/documents/detail/{pid}) by using
the same params as the part-of component.
Closes rero/rero-ils#4022
Co-Authored-by: Pascal Repond <pascal.repond@rero.ch>
Translate-URL: https://hosted.weblate.org/projects/rero_plus/ Co-authored-by: Pascal Repond <pascal.repond@rero.ch>
Co-Authored-by: Pascal Repond <pascal.repond@rero.ch>
- Fix editor error with ngx-formly>7.0.0. - Browser compatibility expansion for older browsers in public apps. Co-Authored-by: Pascal Repond <pascal.repond@rero.ch>
- Depends on rero/rero-ils#4008. Co-Authored-by: Pascal Repond <pascal.repond@rero.ch>
Co-Authored-by: Pascal Repond <pascal.repond@rero.ch>
Co-Authored-by: Pascal Repond <pascal.repond@rero.ch>
* If a `sort_date` exists in the db item, it is displayed in the brief and detailed view. * Depends on rero/rero-ils#4034. * Closes rero/rero-ils#4032. Co-Authored-by: Pascal Repond <pascal.repond@rero.ch>
Bump Angular and related devkit packages from 19.2.19 to 19.2.20, along with various transitive dependency updates. Co-Authored-by: Pascal Repond <pascal.repond@rero.ch>
Remove the Node.js matrix strategy (18.19.x, 20.11.x, 22.x) and fix the CI to Node.js 22 only. Node 18 (end-of-life since April 2025) ships with npm 9.x which has a known bug with optional native dependencies (npm/cli#4828). This caused @tailwindcss/oxide to fail loading its native binding on CI. Testing multiple Node versions brings no value for a frontend Angular library: the compiled output targets browsers, not Node.js. The publishing workflow already uses Node 22, so the build workflow now mirrors it. Co-Authored-by: Pascal Repond <pascal.repond@rero.ch>
* Closes rero/rero-ils#4043. * Depends on rero/rero-ils#4045. Co-Authored-by: Pascal Repond <pascal.repond@rero.ch>
When a document linked to an acq_order_line or acq_receipt_line is deleted, fetching it now fails gracefully instead of propagating the HTTP 404 error. - order-line: fetch document in ngOnInit via forkJoin with catchError; display "Unknown document" when the document no longer exists - receipt-line: replace getRecord pipe with a reactive signal that catches errors; display "Unknown document" on 404; remove stale console.log - formly order-line type: wrap document fetch in catchError; store extracted document pid in a dedicated property (document data uses $ref format, not pid); display "Unknown document" fallback with correct pid while keeping order-line notes visible - documents remote autocomplete: add catchError to getValueAsHTML so that the order-line editor no longer throws a console error and shows a readable "Unknown document (pid X)" fallback when the linked document no longer exists Relates to rero/rero-ils#3818 Co-Authored-by: Pascal Repond <pascal.repond@rero.ch>
Show the location's public_note field below the location name in: - the admin location detail view - the public and admin document detail view Also exclude iOS Safari < 15 from the browserslist config across all public projects to avoid build problems because of import.meta. Related to rero/rero-ils#4040. Co-Authored-by: Pascal Repond <pascal.repond@rero.ch>
Add `flex-1` to the content column of `description-zone` to ensure consistent alignment when text is long. Refactor `other-edition` block view to use `shared-description-zone` instead of duplicating the two-column layout. Co-Authored-by: Pascal Repond <pascal.repond@rero.ch>
Closes rero/rero-ils#4020. Updates dependencies. When a multi-org patron switched organisations on their profile, the list of loaned documents was reloaded but the contributor field kept showing data from the first org. This happened because Angular reused the PatronProfileDocumentComponent instances (track $index) and only updated the @input, while ngOnInit — the only place the document was fetched — was never called again. Refactor the component to use Angular 19 signal inputs (input()) and replace the imperative ngOnInit/ngOnChanges lifecycle with a reactive toSignal(toObservable(record).pipe(switchMap(...))) chain. The switchMap automatically cancels any in-flight request and re-fetches the document whenever the record input changes, fixing the stale data. Co-Authored-by: Pascal Repond <pascal.repond@rero.ch>
Translate-URL: https://hosted.weblate.org/projects/rero_plus/ Co-Authored-by: Pascal Repond <pascal.repond@rero.ch>
Following the backend thumbnail refactor (rero/rero-ils#4018), the responsibility for thumbnail resolution and display is now fully on the backend. The frontend now only displays the existing thumbnail in the database, or the default SVG. Co-Authored-by: Pascal Repond <pascal.repond@rero.ch>
* "Scan" was confusing for users, "check-in/checkout" is more intuitive. Co-Authored-by: Pascal Repond <pascal.repond@rero.ch>
Co-Authored-by: Pascal Repond <pascal.repond@rero.ch>
Co-Authored-by: Pascal Repond <pascal.repond@rero.ch>
Co-Authored-by: Pascal Repond <pascal.repond@rero.ch>
…ge detection - Upgrade to Angular 21 (standalone components, strict TypeScript, Vitest) - Adopt NgRx Signal Store for reactive state management, replacing RxJS-based patterns - Enable zoneless change detection; use Angular Signals throughout - Refactor search, aggregations, record detail, and editor as signal-driven stores - Migrate Formly and PrimeNG components to latest APIs and CSS cascade layer model - Update CI workflows and dependency lockfile Co-Authored-By: Bertrand Zuchuat <bertrand.zuchuat@rero.ch> Co-Authored-By: Johnny Mariethoz <johnny.mariethoz@rero.ch>
Translate-URL: https://hosted.weblate.org/projects/rero_plus/ Co-Authored-by: Pascal Repond <pascal.repond@rero.ch>
Co-Authored-by: Pascal Repond <pascal.repond@rero.ch>
* Closes rero/rero-ils#4109. Co-Authored-by: Bertrand Zuchuat <bertrand.zuchuat@rero.ch>
* Changes alert type from error to warn. * Removes sticky parameter, it needs to be false to remove the toast. * Closes rero/rero-ils#4087. Co-Authored-by: Ana Gomes <anagoncalves7@icloud.com>
- LibraryComponent: use getRecordWithEtag() and pass If-Match on PUT - UserIdEditorComponent: guard against double-submit; handle 409 conflict - PatronProfilePersonalEditorComponent: same as above - /users/ endpoints do not support ETag (no If-Match sent) but backend returns 409 on concurrent SQLAlchemy writes — warn message shown accordingly Co-Authored-by: Johnny Mariéthoz <johnny.mariethoz@rero.ch>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
receptiontab on order detail viewcreation_datefieldenumerationAndChronologyfieldidentifiedByduplicate check.npm linkissue_sort_dateLibraryeditor