fix(codex): filter invalid generic item IDs - #2357
Open
moyuan10086 wants to merge 1 commit into
Open
moyuan10086 wants to merge 1 commit into
moyuan10086 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
input[*].idvalues matching the invalid genericitem_*prefixservice_tierpayload defaultThis prevents resumed Codex conversations from failing with errors such as
invalid_id_prefixwhen stored response items carry generic IDs that do not match their required typed prefixes (rs,fc, and others).Fixes #1773
Validation
cargo check -p cockpit-tools --testspassesgit diff --checkpassesOn this Windows host, the compiled Rust test executable is currently blocked before the test harness starts by system loader error
0xc0000139 (STATUS_ENTRYPOINT_NOT_FOUND). The test target itself compiles successfully; CI can execute it in a clean runner.