Skip to content

fixes to get auto_selfcal to run cleanly with allow_cocal=True - #116

Merged
jjtobin merged 31 commits into
mainfrom
fix_cocal
Jun 14, 2026
Merged

fixes to get auto_selfcal to run cleanly with allow_cocal=True#116
jjtobin merged 31 commits into
mainfrom
fix_cocal

Conversation

@jjtobin

@jjtobin jjtobin commented May 1, 2026

Copy link
Copy Markdown
Owner

With various changes introduced recently, co-cal, the application of solutions from successfully self-calibrated targets to non-self-calibrated targets was non-functional. The purpose of this PR is to fix the co-cal code.

@codecov-commenter

codecov-commenter commented May 1, 2026

Copy link
Copy Markdown

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

❌ Patch coverage is 76.68539% with 83 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
auto_selfcal/mosaic_helpers.py 47.82% 48 Missing ⚠️
auto_selfcal/run_selfcal.py 61.36% 17 Missing ⚠️
auto_selfcal/prepare_cocal.py 91.01% 8 Missing ⚠️
auto_selfcal/gaincal_wrapper.py 92.04% 7 Missing ⚠️
auto_selfcal/selfcal_helpers.py 83.33% 3 Missing ⚠️
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.
Files with missing lines Coverage Δ
auto_selfcal/auto_selfcal.py 72.18% <100.00%> (+13.52%) ⬆️
auto_selfcal/prepare_selfcal.py 91.06% <100.00%> (+0.29%) ⬆️
auto_selfcal/tests/test_auto_selfcal.py 64.34% <100.00%> (ø)
auto_selfcal/selfcal_helpers.py 70.83% <83.33%> (+2.40%) ⬆️
auto_selfcal/gaincal_wrapper.py 88.03% <92.04%> (+15.13%) ⬆️
auto_selfcal/prepare_cocal.py 91.01% <91.01%> (ø)
auto_selfcal/run_selfcal.py 74.69% <61.36%> (+4.52%) ⬆️
auto_selfcal/mosaic_helpers.py 62.08% <47.82%> (-14.58%) ⬇️

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

jjtobin and others added 23 commits May 4, 2026 14:55
…fb solints. This includes removing the stapling together of existing gaintables for inf_fb3, and also splitting cocal preparation into prepare_cocal.
…aincal as is used for applycal when doing the inf_fb* modes, because in those cases the same table might not be used for both.
…pw data have a solution populated for all solints
@jjtobin
jjtobin merged commit 4d48dac into main Jun 14, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants