Conversation
drieber
self-requested a review
September 16, 2026 17:57
Contributor
|
This looks good to me. It is very valuable to have this test confirming this somewhat subtle behavior. |
yuja
approved these changes
Sep 17, 2026
This already works, but I tripped on this detail when working on an alternate backend. This test may be more valuable as documentation/confirmation of intended behavior than anything else.
Author
|
Made requested nit change, and also added myself to paid_reviewers.md as a Google employee (not on the jj team). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This already works, but I tripped on this detail when working on an alternate backend. This test may be more valuable as documentation/confirmation of intended behavior than anything else.