Skip to content

Take non-materialized .gitignore into account in sparse working copies - #10188

Open
twistedfall wants to merge 1 commit into
jj-vcs:mainfrom
twistedfall:sparse-gitignore
Open

twistedfall wants to merge 1 commit into
jj-vcs:mainfrom
twistedfall:sparse-gitignore

Conversation

@twistedfall

Copy link
Copy Markdown

When .gitignore is sparsed-away it stops affecting the file tracking status and files that were supposed to be ignored become tracked as soon as .gitignore disappears. This change allows us to look up the .gitignore files in the repository and take them into account.

Fixes #2289

Checklist

If applicable:

  • I have updated CHANGELOG.md
  • I have updated the documentation (README.md, docs/, demos/)
  • I have updated the config schema (cli/src/config-schema.json)
  • I have added/updated tests to cover my changes
  • I fully understand the code that I am submitting (what it does,
    how it works, how it's organized), including any code drafted by an LLM.
  • For any prose generated by an LLM, I have proof-read and copy-edited with
    an eye towards deleting anything that is irrelevant, clarifying anything
    that is confusing, and adding details that are relevant. This includes,
    for example, commit descriptions, PR descriptions, and code comments.

@twistedfall
twistedfall requested a review from a team as a code owner September 13, 2026 20:44
@google-cla

google-cla Bot commented Sep 13, 2026

Copy link
Copy Markdown

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The following commits do not follow our format for subject lines:

  • 4a313df: Take non-materialized .gitignore into account in sparse working copies

Commits should have a subject line following the format <topic>: <description>. Please review the commit guidelines for more information.

@github-actions
github-actions Bot dismissed their stale review September 13, 2026 21:09

All commits are now correctly formatted. Thank you for your contribution!

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The following commits do not follow our format for subject lines:

  • 7e63f4f: Take .gitignore into account in sparse copies

Commits should have a subject line following the format <topic>: <description>. Please review the commit guidelines for more information.

@github-actions
github-actions Bot dismissed their stale review September 17, 2026 09:29

All commits are now correctly formatted. Thank you for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

.gitignores should probably be respected even if sparsed-away

1 participant