Repository navigation
Conversation
The CLI sends request bodies as given, so a change to a body schema moves nothing it does: only its tests read those schemas. spec-diff titled such a sync a feat all the same, and the first sync of the English spec would have released a version with no change in it and a changelog line saying otherwise. A sync is now a feat when the method, path or parameters of an operation the CLI calls change, or a list of values a flag reads with choices or bodyChoices; spec-diff reads those lookups off the source and stops on one that does not name its operation and field in literals, which is why the refund and payout options now take their lists from the call site. A body, an operation the CLI does not call, or prose is a chore. Refs: #T17509 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
entry count refused an eleventh container before sending. The limit is in openapi.yaml's prose, not its schema, so the CLI kept its own copy of it, and that copy would go on refusing after the API took more. The API answers more than it takes with a 400 that says so. The help still says up to 10. Refs: #T17509 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The payment commands' help named order, refund and payout numbers and the payment channels in Chinese; openapi.yaml now names them in English, with the parameter each one is: trade_no, merchant_out_trade_no, out_trade_no, refund_no. 小金商户 stays, as the spec keeps it. Refs: #T17509 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#53 was stacked on #51 and merged into #51's branch after #51 had already been squash-merged, so its three commits never reached
main. This brings them over unchanged: the tree matchesyiichou/feat-qunli-t17509exactly. The description, discussion and test results are on #53.ci:spec-diffreleases a sync only when what the CLI checks or offers at run time changed: the method, path or parameters of an operation it calls, or a list of values a flag reads. A body, an operation it does not call, or prose is achore.fix:entry countleaves how many containers it may name to the API (11 now gets the API's 400, exit 5, instead of a local exit 2).docs:the payment help names order, refund and payout numbers as openapi.yaml does.This should merge before spec-sync is first run by hand: on
mainas it is, the old rule would title the sync of the English spec afeatand cut an empty release.npm run checkandnpm test(282 tests) pass on this branch.Refs: #T17509
🤖 Generated with Claude Code