Repository navigation
Clarify 'Disc' disconnect channels, validate DMR ID binding, and allow hotspot-only generation - #10
Merged
Conversation
…w hotspot-only generation - csv_export & README: clarify that TG 4000 channels labeled 'Disc' are Disconnect channels (not Discovery) - models.py: validate that radio_name is populated and matches channel dmr_id - web/app.py: allow codeplug generation when repeaters is empty if hotspot talkgroups or analog repeaters are selected - tests: add comprehensive test suite for web generate endpoint, DMR ID referential integrity, and edge cases
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Addresses feedback from issue #4:
Codeplug.validate()to ensureradio_nameis set and all channels have theirdmr_idmatchingradio_name.codeplug/csv_export.py(README.txt) andREADME.mdthat TG 4000 channels labeledDisc(e.g.HS Disc) are mandatory Disconnect channels (used to unlink reflectors/talkgroups on BrandMeister/DMR-MARC), not 'Discovery' channels.web/app.pyso users who only select hotspot talkgroups or analog repeaters can generate a codeplug without hitting a 400 'No repeaters selected' error.tests/test_web_generate.pycovering web generate referential integrity, hotspot-only, analog-only, and error cases.Closes #4