Fix LMS ptr race condition and prefetch underflow in kiss sorter - #9
Open
pudding0803 wants to merge 1 commit into
Open
Fix LMS ptr race condition and prefetch underflow in kiss sorter#9pudding0803 wants to merge 1 commit into
pudding0803 wants to merge 1 commit into
Conversation
get_lms() advanced SA's write pointer for every suffix instead of only LMS positions, letting parallel threads overwrite each other's ranges. induced_L_block_update/prepare could underflow their loop bounds when state.m or state.len was smaller than the prefetch distance. Also add a guard in FMIndex::get_offsets/fmtree to skip already-sampled offsets before calling lf, avoiding redundant/incorrect recomputation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #8
get_lms() advanced SA's write pointer for every suffix instead of only LMS positions, letting parallel threads overwrite each other's ranges. induced_L_block_update/prepare could underflow their loop bounds when state.m or state.len was smaller than the prefetch distance. Also add a guard in FMIndex::get_offsets/fmtree to skip already-sampled offsets before calling lf, avoiding redundant/incorrect recomputation.