Skip to content

Update plc eval test case for version-aware verdicts - #2

Merged
jhadvig merged 1 commit into
jhadvig:jhadvig/ota-2024-cluster-update-evalsfrom
jrangelramos:fix/plc-eval-version-aware-verdicts
Jul 24, 2026
Merged

Update plc eval test case for version-aware verdicts#2
jhadvig merged 1 commit into
jhadvig:jhadvig/ota-2024-cluster-update-evalsfrom
jrangelramos:fix/plc-eval-version-aware-verdicts

Conversation

@jrangelramos

Copy link
Copy Markdown
Collaborator

Summary

  • Update plc_proposal_olm_batch_check eval test case to match the
    new per-operator verdict output from OTA-2070: Return per-operator verdicts from olm-check openshift/agentic-skills#43
  • Replace coarse "has/doesn't have lifecycle data" counts with three
    granular counts: operators_api_tracked_count,
    operators_version_tracked_count, operators_ocp_compatible_count
  • Switch cluster-logging from v6.5.1 to v6.3.1 to test the
    "tracked but not OCP-compatible" case

Context

PR openshift#43 refactored olm-check to return explicit found: true/false
verdicts per operator+version instead of dumping all version entries.
This eval change exercises that new output structure so evals validate
the correct 4/3/2 split in the test plc_proposal_olm_batch_check:

Count Value Why
operators_api_tracked_count 4 devworkspace-operator not in API
operators_version_tracked_count 3 web-terminal v1.16 not tracked (only up to v1.15)
operators_ocp_compatible_count 2 cluster-logging v6.3 is not compatible with OCP 4.21

Test plan

  • Run evals with all three providers to confirm consistent 4/3/2 results

Align plc_proposal_olm_batch_check with the new olm-check output
from openshift#43: test the version-aware found/not-found split instead of
the old all-versions dump.

Changes:
- Switch cluster-logging to v6.3.1 (tracked but not OCP 4.21 compatible)
- Replace operators_with/without_lifecycle_data with three finer counts:
  api_tracked (4), version_tracked (3), ocp_compatible (2)
- Update query to ask for per-version and compatibility breakdown
@jrangelramos

Copy link
Copy Markdown
Collaborator Author

tests here openshift#43 (comment) and here openshift#43 (comment)

@jhadvig jhadvig left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@jhadvig
jhadvig merged commit f5657d8 into jhadvig:jhadvig/ota-2024-cluster-update-evals Jul 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants