Add test cases for attribute specs that fail on grammar - #148
Merged
Merged
Conversation
The "Non-attributes" cases all fail for want of a closing brace, and the
terminated specs that are rejected elsewhere -- {#a<b} above, and
spans.test's [not a span]{#a<b} -- fail on an invalid character in a
name. A spec that is terminated and whose characters are all legal, but
whose contents aren't attributes, is a third way to fail: it leaves
SCANNING_KEY or SCANNING_VALUE with no value to take. That path isn't
covered.
A bare key has no `=` at all; `key=` has one with nothing after it. Note
the emptiness is what a *bare* value can't be -- `{key=""}` is accepted
and yields key="" -- so `{key=}` is the case that pins it.
The block form is here for the same reason as the `{a=x` + "# non-heading"
case above it, plus one thing that case can't show: a spec holding a
valid attribute alongside an invalid one applies neither, so `.a` is not
a class and the heading below stays literal.
All three pass on main.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The "Non-attributes" cases all fail for want of a closing brace, and the terminated specs that are rejected elsewhere -- {#a<b} above, and spans.test's [not a span]{#a<b} -- fail on an invalid character in a name. A spec that is terminated and whose characters are all legal, but whose contents aren't attributes, is a third way to fail: it leaves SCANNING_KEY or SCANNING_VALUE with no value to take. That path isn't covered.
A bare key has no
=at all;key=has one with nothing after it. Note the emptiness is what a bare value can't be --{key=""}is accepted and yields key="" -- so{key=}is the case that pins it.The block form is here for the same reason as the
{a=x+ "# non-heading" case above it, plus one thing that case can't show: a spec holding a valid attribute alongside an invalid one applies neither, so.ais not a class and the heading below stays literal.