bug regarding pawn captures - #7
Open
michelflatres wants to merge 2 commits into
Open
Conversation
solved bug about pawn capture logic
solve minor bug regarding pawn capture
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a white pawn is in row 5 (or row 4 for black) and an opponent pawn on a adjacent column is still in is starting position (row 2 or 7 for white or black), if the opponent move one square forward (instead of the 2 required for en passant), the game will say that capturing it is an illegal move, even though it's perfectly legal, it has nothing different than any other pawn capture. The issue is that the "else if" condition is met (the pawn is on the required row), but further conditions are not met (opponent pawn moving 2 square), meaning that the program consider true the condition for the else if, therefore skipping the following else if, where normal diagonal pawn capture is implemented. To fix this I separated these parts, so that en passant and pawn capture aren't anymore connected in the same else if chain.